Use isinstance() instead of type() #7501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
backport-7
backport-8
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7502 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Replace type comparisons with isinstance() checks. * Add changelog. (cherry picked from commit 48e860b)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #7503 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Replace type comparisons with isinstance() checks. * Add changelog. (cherry picked from commit 48e860b)
felixfontein
added a commit
that referenced
this pull request
Nov 8, 2023
…pe() (#7502) Use isinstance() instead of type() (#7501) * Replace type comparisons with isinstance() checks. * Add changelog. (cherry picked from commit 48e860b) Co-authored-by: Felix Fontein <[email protected]>
felixfontein
added a commit
that referenced
this pull request
Nov 8, 2023
…pe() (#7503) Use isinstance() instead of type() (#7501) * Replace type comparisons with isinstance() checks. * Add changelog. (cherry picked from commit 48e860b) Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix sanity tests.
Ref: https://dev.azure.com/ansible/community.general/_build/results?buildId=95127&view=logs&j=989d489a-4f0d-5fce-ef97-861a3aa8f466&t=7f12bb05-38e3-5790-48be-85ee2e060d6b
ISSUE TYPE
COMPONENT NAME
several module utils